Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enum lowering and option to take snapshots. #575

Merged
merged 13 commits into from
May 9, 2024
Merged

Enum lowering and option to take snapshots. #575

merged 13 commits into from
May 9, 2024

Conversation

lkorenc
Copy link
Contributor

@lkorenc lkorenc commented Apr 26, 2024

Adds pass that lowers enum.

Adds -vast-snapshot-at=pass1; ... ;passN to vast-front that will store MLIR module after given pass. I plan to use this to streamline test definition and eliminate redundant pipeline redefinitions.

xlauko
xlauko reviewed Apr 29, 2024
View reviewed changes
lib/vast/Conversion/FromHL/EmitLazyRegions.cpp Show resolved Hide resolved
lib/vast/Conversion/FromHL/Passes.cpp Outdated Show resolved Hide resolved
lib/vast/Frontend/Options.cpp Show resolved Hide resolved
lib/vast/Conversion/FromHL/LowerEnums.cpp Outdated Show resolved Hide resolved
@lkorenc lkorenc mentioned this pull request Apr 29, 2024
Merged
@lkorenc lkorenc marked this pull request as ready for review May 7, 2024 11:19
xlauko
xlauko reviewed May 8, 2024
View reviewed changes
include/vast/Util/Pipeline.hpp Show resolved Hide resolved
test/vast/Conversion/enum-a.c Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2024

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-format reports: 7 file(s) not formatted
  • include/vast/Util/Pipeline.hpp
  • lib/vast/Conversion/FromHL/EmitLazyRegions.cpp
  • lib/vast/Conversion/FromHL/ToLLGEPs.cpp
  • lib/vast/Dialect/HighLevel/HighLevelOps.cpp
  • lib/vast/Dialect/HighLevel/Transforms/LowerEnums.cpp
  • lib/vast/Frontend/Consumer.cpp
  • lib/vast/Frontend/Pipelines.cpp
clang-tidy reports: 4 concern(s)

  • include/vast/Util/Pipeline.hpp:176:17: error: [clang-diagnostic-error]

    use of undeclared identifier 'gap'

      176 |         virtual gap::generator< pipeline_step_ptr > substeps() const = 0;
      |                 ^

  • include/vast/Util/Pipeline.hpp:178:9: error: [clang-diagnostic-error]

    use of undeclared identifier 'gap'

      178 |         gap::generator< pipeline_step_ptr > dependencies() const;
      |         ^

  • include/vast/Util/Pipeline.hpp:200:9: error: [clang-diagnostic-error]

    use of undeclared identifier 'gap'

      200 |         gap::generator< pipeline_step_ptr > substeps() const override;
      |         ^

  • include/vast/Util/Pipeline.hpp:234:9: error: [clang-diagnostic-error]

    use of undeclared identifier 'gap'

      234 |         gap::generator< pipeline_step_ptr > substeps() const override;
      |         ^

Have any feedback or feature suggestions? Share it here.

@lkorenc lkorenc merged commit a5c6f9e into master May 9, 2024
8 checks passed
@lkorenc lkorenc deleted the lower-enums branch May 9, 2024 13:00
@lkorenc lkorenc mentioned this pull request Jun 3, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xlauko xlauko xlauko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lkorenc @xlauko